Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ospf6d: resolve problem with area range lsid creation #38

Merged
merged 1 commit into from
Jan 13, 2017
Merged

ospf6d: resolve problem with area range lsid creation #38

merged 1 commit into from
Jan 13, 2017

Conversation

donaldsharp
Copy link
Member

The problem reported was that routers downstream from the ABR would have
prefixes in the IPv6 rib that should have been summarized. Testing showed
that the prefixes were absent in the lsdb but not removed from the rib.

The problem (and others) stemmed from determining the link-state id to use
for the area-range statement only from other entries in the range-table. Since
the area range statement creates inter-prefix LSAs (summaries) which are in all
aspects identical to other inter-prefix LSAs, the number space for the lsid
needs to be unique across all inter-prefix LSAs, not just unique between area
range statements. This fix removes the use of range-table specific lsids and
acquires the lsid just as any other inter-prefix LSA.

Ticket: CM-13626
Signed-off-by: Don Slice
Reviewed By: CCR-5489
Testing Done: Manual testing, repeated runs of the test that previously failed,
ospf-smoke

@dslicenc @donaldsharp
ospf6d: resolve problem with area range lsid creation
54c8d91 
The problem reported was that routers downstream from the ABR would have
prefixes in the IPv6 rib that should have been summarized.  Testing showed
that the prefixes were absent in the lsdb but not removed from the rib.

The problem (and others) stemmed from determining the link-state id to use
for the area-range statement only from other entries in the range-table. Since
the area range statement creates inter-prefix LSAs (summaries) which are in all
aspects identical to other inter-prefix LSAs, the number space for the lsid
needs to be unique across all inter-prefix LSAs, not just unique between area
range statements.  This fix removes the use of range-table specific lsids and
acquires the lsid just as any other inter-prefix LSA.

Ticket: CM-13626
Signed-off-by: Don Slice
Reviewed By: CCR-5489
Testing Done: Manual testing, repeated runs of the test that previously failed,
ospf-smoke
@donaldsharp
Copy link
Member Author

This is to address: #3

@NetDEF-CI
Copy link
Collaborator

Continous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

CentOS6 amd64 build: Successful
OmniOS amd64 build: Successful
Fedora24 amd64 build: Successful

NetBSD7 amd64 build: Failed

Package building failed for NetBSD7 amd64 build
see package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI012BUILD/ErrorLog/log_package_build.txt
NetBSD7 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI012BUILD/config.status/config.status

Ubuntu1604 amd64 build: Failed

Package building failed for Ubuntu1604 amd64 build:
(see full package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI014BUILD/ErrorLog/log_package_build.txt)

debian/rules:22: "MPLS enabled"
# Quagga needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
dh_auto_configure -- \
 		--enable-exampledir=/usr/share/doc/quagga/examples/ \
	--localstatedir=/var/run/quagga \
	--sbindir=/usr/lib/quagga \
	--sysconfdir=/etc/quagga \

Ubuntu1604 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI014BUILD/config.status/config.status

NetBSD6 amd64 build: Failed

Package building failed for NetBSD6 amd64 build
see package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI007BUILD/ErrorLog/log_package_build.txt
NetBSD6 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI007BUILD/config.status/config.status

FreeBSD9 amd64 build: Failed

Package building failed for FreeBSD9 amd64 build
see package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI004BUILD/ErrorLog/log_package_build.txt
FreeBSD9 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI004BUILD/config.status/config.status

CentOS7 amd64 build: Failed

Package building failed for CentOS7 amd64 build
see package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS7 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI005BUILD/config.status/config.status

Ubuntu1204 amd64 build: Failed

Package building failed for Ubuntu1204 amd64 build:
(see full package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI002BUILD/ErrorLog/log_package_build.txt)

debian/rules:24: "MPLS disabled"
# Quagga needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
dh_auto_configure -- \
 		--enable-exampledir=/usr/share/doc/quagga/examples/ \
		--localstatedir=/var/run/quagga \
		--sbindir=/usr/lib/quagga \
		--sysconfdir=/etc/quagga \

Ubuntu1204 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI002BUILD/config.status/config.status

Debian8 amd64 build: Failed

Package building failed for Debian8 amd64 build:
(see full package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI008BLD/ErrorLog/log_package_build.txt)

debian/rules:10: "DEBIAN: SNMP disabled, see README.Debian"
# Quagga needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/quagga/examples/ \
	--localstatedir=/var/run/quagga \
	--sbindir=/usr/lib/quagga \
	--sysconfdir=/etc/quagga \

Debian8 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI008BLD/config.status/config.status

FreeBSD10 amd64 build: Failed

Package building failed for FreeBSD10 amd64 build
see package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI003BUILD/ErrorLog/log_package_build.txt
FreeBSD10 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI003BUILD/config.status/config.status

Ubuntu1404 amd64 build: Failed

Package building failed for Ubuntu1404 amd64 build:
(see full package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI001BUILD/ErrorLog/log_package_build.txt)

debian/rules:24: "MPLS disabled"
# Quagga needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
dh_auto_configure -- \
 		--enable-exampledir=/usr/share/doc/quagga/examples/ \
		--localstatedir=/var/run/quagga \
		--sbindir=/usr/lib/quagga \
		--sysconfdir=/etc/quagga \

Ubuntu1404 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI001BUILD/config.status/config.status

OpenBSD60 amd64 build: Failed

Package building failed for OpenBSD60 amd64 build:
(see full package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI011BUILD/ErrorLog/log_package_build.txt)

Error: /home/ci/cibuild.8/myport/pobj/quagga-test-20170103.201901-git.54c8d91/fake-amd64/usr/local/include/quagga/quagga/zclient.h does not exist
Error: /home/ci/cibuild.8/myport/pobj/quagga-test-20170103.201901-git.54c8d91/fake-amd64/usr/local/include/quagga/quagga/zebra.h does not exist
Fatal error: can't continue
 at /usr/libdata/perl5/OpenBSD/PkgCreate.pm line 1500.
*** Error 1 in . (/home/ci/cibuild.8/myport/infrastructure/mk/bsd.port.mk:1895 '/home/ci/cibuild.8/myport/packages/amd64/all/quagga-test-20170103.201901p0-git.54c8d91.tgz')
*** Error 1 in . (/home/ci/cibuild.8/myport/infrastructure/mk/bsd.port.mk:2416 '_internal-package')
*** Error 1 in /home/ci/cibuild.8/myport/net/quagga-test (/home/ci/cibuild.8/myport/infrastructure/mk/bsd.port.mk:2396 'package')
gmake: *** [Makefile:63: pkg] Error 1

OpenBSD60 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI011BUILD/config.status/config.status

FreeBSD11 amd64 build: Failed

Package building failed for FreeBSD11 amd64 build
see package build log at /browse/FRR-FRRPULLREQ-8/artifact/CI009BUILD/ErrorLog/log_package_build.txt
FreeBSD11 amd64 build: Unknown Log <config.status>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8/artifact/CI009BUILD/config.status/config.status

@eqvinox
Copy link
Contributor

eqvinox commented Jan 13, 2017

test failures are rename related, fix looks OK - merging.

@eqvinox eqvinox merged commit ccc4bd3 into FRRouting:stable/2.0 Jan 13, 2017
@eqvinox eqvinox mentioned this pull request Jan 13, 2017
Closed
@donaldsharp donaldsharp deleted the stable_ospf6_fix branch May 17, 2017 12:01
cfra referenced this pull request in opensourcerouting/frr Nov 29, 2018
@donaldsharp
Merge pull request #38 from opensourcerouting/eigrp_table_v2
240f743 
Solve EIGRP topo output ordering problem
ranjanyash54 pushed a commit to ranjanyash54/frr that referenced this pull request Sep 21, 2021
@pushpasis
Merge pull request FRRouting#38 from ranjanyash54/bug_fix
e70afab 
cmgd: Throw a warning instead of error when reading empty config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donaldsharp @NetDEF-CI @eqvinox @dslicenc